Just a few quick ones right off of the top of my head......
Instructors need to be excellent communicators. I don't care if an instructor can run his gun like I've never seen in my life. If his communication skills are sub par then the class becomes nothing more than a waste of time and ammo.
Instructors must also play the role of a coach. The self defense training world isn't like sports where you have a coach with you during practice/training making sure you are maximizing your resources. Coach us up on how we can train outside of the class.
Instructors must be in control of the training environment at all times. I want them to keep the environment safe such as the standard four rules of firearm safety or have strict policies on keep FOF training environments sterile. I also want them to stay on task and follow the class itinerary/lesson plans to the best of their abilities. While I enjoy a good conversation with instructors and fellow students, I don't want those conversations to ever get to a point where it takes away from learning.