Your design is very similar to that used by Hunter, Buccheimer, and several others over the past 80 years or so. Simple envelope-style holster body with a folded belt loop connected by a snap-loop around the holster, and a snap-strap retention. Perfectly adequate for many needs in field, range, farm, and ranch applications.
Advice to offer? Be careful! I started doing leather holsters in about 1972 as a young cop trying to make what I needed without taking anything out of the family budget that was already stressed with house payments and feeding a couple of hungry kids. Before long I was making products for the guys I worked with, then the word spread around and I was pounding hides during much of my off-duty time. Started a little sideline business with a few bucks for a new tool here and there, started getting creative with my own interpretations of other popular makers and their designs. Part-time business lasted until my retirement, which corresponded with the new INTERNET era. Put up a website and before I knew what hit me I was working 7 days every week for the next 20 years trying to keep up with orders, shipping to all 50 US states and more than 30 foreign countries. Grew out of the garage, out of the house, rented shop space, eventually purchasing and refurbishing a commercial building while also hiring and training others to assist in the basic production.
Be careful what you wish for because you might find it. Lots of demand, more than enough for another capable person with the willingness to learn and build a business. Even better for the people who have the gift of visualizing the final product and making it appear on paper, in prototype form, revising as needed, and delivering to the market only when it has been tested and ready for the intended use, then standing behind their workmanship with warranty service.
Leatherworking can be a hobby or it can be a business. I hope you make sure your choice is made up front. A hobby can be rewarding, but running a business takes a bit toll on you (emotionally and physically) and everyone close to you.
I am an old retired guy now, just looking back on my life since I was young and ready to chase any opportunity to get ahead.
Best regards.